Save children dtypes/length in ZstdBuffersMetadata#8572
Conversation
Signed-off-by: Mikhail Kot <mikhail@spiraldb.com>
myrrc
force-pushed
the
myrrc/zstdbuffers-deser-issue
branch
from
3e06503 to
d2fb1e7
Compare
Merging this PR will not alter performance
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ❌ | Simulation | chunked_varbinview_into_canonical[(1000, 10)] |
168.8 µs | 205.6 µs | -17.87% |
| ❌ | Simulation | slice_empty_vortex |
310 ns | 368.3 ns | -15.84% |
| ⚡ | Simulation | chunked_varbinview_opt_canonical_into[(1000, 10)] |
205.9 µs | 169.4 µs | +21.54% |
| ⚡ | Simulation | eq_i64_constant |
318.6 µs | 288.7 µs | +10.35% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing myrrc/zstdbuffers-deser-issue (d2fb1e7) with develop (cfdece3)
Footnotes
-
4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
2 participants
Before this change, ZstdBuffers::deserialize set children's dtype
to its own dtype. In ZstdBuffers children belong to inner encodings and
they have their own dtypes. This triggered a deserialization issue.
Add children dtypes and lengths to metadata.
Resolves: #8549